Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Restored default value for write_bounding_box #320

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

Hororohoruru
Copy link
Contributor

Restored the previous value for the write_bounding_box parameter, as mentioned in #312

Since it seems to be a fixed value, I could also add a keyword argument to do_subject_normalize and put this default value there, so is easily accesible in case it needs change.

@thomasbazeille
Copy link

CircleCI fails as usual, because of SPM installation problem unrelated to the PR.

TravisCI for another unrelated reason linked to #210 and coming from a bad test design that creates non-deterministic test failure. When a maintainer is reviewing this, please rebuild TravisCI job and it should work.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bthirion
Copy link
Member

@AGrigis any opinion ?

@AGrigis
Copy link
Member

AGrigis commented Mar 26, 2019

I added this parameter for the IMAGEN processings in order to work with a non-MNI template.
As it is not the usual way to preprocess data, I think you can restaure the former hardcoded value.

@bthirion
Copy link
Member

OK, merging. Thx.

@bthirion bthirion merged commit f8e0b2d into neurospin:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants