Eg mod #338
Merged
Eg mod #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bthirion
reviewed
Nov 25, 2020
| @@ -30,12 +30,12 @@ | |||
|
|
|||
| # Path (relative or full) of directory containing data (if different from directory | |||
| # containing this configuration file). | |||
| dataset_dir = | |||
| dataset_dir = | |||
There was a problem hiding this comment.
I've removed the NYU rest ini file. The NYU rest example is obviously not the only one showcasing use of ini files. Was there a specific reason for including this dataset?
There was a problem hiding this comment.
O that's an ini file, sorry.
Anyway, if the fetcher is deprecated, it's better to remove it (as you may have seen, Nilearn has examples on a new resting state dataset).
Best,
B
bthirion
approved these changes
Nov 26, 2020
|
Maybe a rebase to remove conflicts ? |
|
@bthirion The conflicts have been resolved, should I merge once the tests are complete? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the example file nipype_preproc_spm_nyu because 1) it errors, and 2) it uses the NYU rest fetcher which is deprecated. I will rework this example with a different dataset later because it showcases the use of an ini file.
The example coreg_demos uses the ABIDE dataset with hardcoded paths; removed it.
Added a line to the README to say that pypreprocess works with Ubuntu 16 and 18, no guarantees otherwise.