Use 1D array in scipy.optimize.minimize
#111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109.
In the latest scipy release, the use of
minimize
withx0.ndim != 1
is being deprecated.Currently, the output of
ub_start = 2 * DerSimonianLaird().fit(y, v, X).params_["tau2"]
is already a 1D array so the use ofminimize
with[ub_start]
givesx0.ndim = 2
, which then gets converted to an array of dimension 0 bynp.squeeze(x0)
, resulting in an error here:https://github.com/scipy/scipy/blob/903bc39809af20a1447ed702e84592397c3de509/scipy/optimize/_minimize.py#L947
Changes proposed in this pull request:
ub_start
inminimize
.