Skip to content

Commit

Permalink
Revert "PCI: Clear PCI_STATUS when setting up device"
Browse files Browse the repository at this point in the history
This reverts commit 6cd514e.

Christophe Fergeau reported that 6cd514e ("PCI: Clear PCI_STATUS when
setting up device") causes boot failures when trying to start linux guests
with Apple's virtualization framework (for example using
https://developer.apple.com/documentation/virtualization/running_linux_in_a_virtual_machine?language=objc)

6cd514e only solved a cosmetic problem, so revert it to fix the boot
failures.

Link: https://bugzilla.redhat.com/show_bug.cgi?id=2137803
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
  • Loading branch information
bjorn-helgaas committed Nov 7, 2022
1 parent 503fa23 commit 44e9859
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/pci/probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -1891,9 +1891,6 @@ int pci_setup_device(struct pci_dev *dev)

dev->broken_intx_masking = pci_intx_mask_broken(dev);

/* Clear errors left from system firmware */
pci_write_config_word(dev, PCI_STATUS, 0xffff);

switch (dev->hdr_type) { /* header type */
case PCI_HEADER_TYPE_NORMAL: /* standard header */
if (class == PCI_CLASS_BRIDGE_PCI)
Expand Down

0 comments on commit 44e9859

Please sign in to comment.