Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMC driver #8

Open
StidOfficial opened this issue Feb 25, 2024 · 2 comments
Open

EMC driver #8

StidOfficial opened this issue Feb 25, 2024 · 2 comments

Comments

@StidOfficial
Copy link

StidOfficial commented Feb 25, 2024

Hi,

I cannot compile correctly the divers on the latest kernel, i got this error :
drivers/net/ethernet/nuvoton/nuvoton-emc.c:769:9: error: implicit declaration of function 'strlcpy'; did you mean 'strscpy'? [-Werror=implicit-function-declaration]

strlcpy seem to be deprecated https://www.kernel.org/doc/html/v6.8-rc4/process/deprecated.html#strlcpy and need to be replace by strscpy.

strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver));
strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version));

EDIT: I also got an issue when udhcpc set ip's :

[   37.040000] nuvoton-emc b0003000.ethernet eth1: NCSI: No channel found to configure!                                                                                    
[   38.080000] nuvoton-emc b0003000.ethernet eth1: Wrong NCSI state 0x100 in workqueue

No IPv4 is set, only IPv6 work.

neuschaefer pushed a commit that referenced this issue Mar 6, 2024
Disable BH around the call to napi_schedule() to avoid following
error:
NOHZ tick-stop error: local softirq work is pending, handler #8!!!

Fixes: ec4c7e1 ("lan78xx: Introduce NAPI polling support")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.kernel.org/r/20240226110820.2113584-1-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
@neuschaefer
Copy link
Owner

Hi,

I cannot compile correctly the divers on the latest kernel, i got this error : drivers/net/ethernet/nuvoton/nuvoton-emc.c:769:9: error: implicit declaration of function 'strlcpy'; did you mean 'strscpy'? [-Werror=implicit-function-declaration]

strlcpy seem to be deprecated https://www.kernel.org/doc/html/v6.8-rc4/process/deprecated.html#strlcpy and need to be replace by strscpy.

strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver));
strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version));

Ah, I'll try to update it when I get around to it. I'll hopefully find some time for WPCM kernel work this weekend.

EDIT: I also got an issue when udhcpc set ip's :

[   37.040000] nuvoton-emc b0003000.ethernet eth1: NCSI: No channel found to configure!                                                                                    
[   38.080000] nuvoton-emc b0003000.ethernet eth1: Wrong NCSI state 0x100 in workqueue

No IPv4 is set, only IPv6 work.

Unfortunately I never really got NCSI to work, and I wonder if it even works on mainline for any other platforms

@neuschaefer
Copy link
Owner

Hi @StidOfficial, I've updated the wpcm-eth branch to build again on top of v6.8-rc7. I haven't use-tested it yet, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants