Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Enable the new eslint-plugin-babel 'babel/quotes' rule #788

Closed
edmorley opened this issue Apr 14, 2018 · 5 comments
Closed

Enable the new eslint-plugin-babel 'babel/quotes' rule #788

edmorley opened this issue Apr 14, 2018 · 5 comments

Comments

@edmorley
Copy link
Member

eslint-plugin-babel v5 (which we updated to in #780) added a new babel/quotes rule, that we presumably will want to enable.

babel/quotes: doesn't complain about JSX fragment shorthand syntax (<>foo</>;)

https://github.com/babel/eslint-plugin-babel#rules

@patiboh
Copy link
Contributor

patiboh commented May 12, 2018

Hi, I'll be happy to do this. This should be enabled in .neutrinorc.js, am I correct?

@edmorley
Copy link
Member Author

Hi!

The rule would need to be added here:
https://github.com/mozilla-neutrino/neutrino-dev/blob/master/packages/airbnb/index.js

@patiboh
Copy link
Contributor

patiboh commented May 14, 2018

Thanks, I’m relatively new at this :)
I’ve read the project’s development process, I’ve done the modification on my branch and ran yarn validate:eslintrc as well as yarn test. Is that sufficient testing for submitting my PR?

@eliperelman
Copy link
Member

@patiboh yes, feel free to submit!

@edmorley
Copy link
Member Author

Fixed by #874.

@edmorley edmorley removed this from the v9 milestone May 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants