Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Enable eslint-plugin-babel's babel/quotes rule #874

Merged
merged 3 commits into from
May 19, 2018

Conversation

patiboh
Copy link
Contributor

@patiboh patiboh commented May 14, 2018

Fix for issue #788

Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me - thank you for the PR!

@eliperelman this rule only applies to JSX, so currently is only enabled in @neutrinojs/airbnb. One option would be to also enable it in @neutrinojs/airbnb-base for consistency - though I'm probably 60:40 against. Just checking your thoughts?

@edmorley
Copy link
Member

edmorley commented May 19, 2018

Sorry to be a pain, but after chatting to @eliperelman we think it might be best to also make the same change to the airbnb-base preset too, just to keep them in sync (and in case people using the Vue preset use airbnb-base instead).

As such, would you mind also updating packages/airbnb/index.js packages/airbnb-base/index.js?

@patiboh
Copy link
Contributor Author

patiboh commented May 19, 2018

Sure , I'll do it :) .. Do you mean in packages/airbnb-base/index.js ?

@edmorley
Copy link
Member

Ah yes that's the one - I pasted the wrong filename haha!

@edmorley edmorley merged commit 878211d into neutrinojs:master May 19, 2018
@edmorley edmorley added this to the v9 milestone May 19, 2018
@edmorley edmorley changed the title Eslint babel quotes Enable eslint-plugin-babel's babel/quotes rule May 19, 2018
@edmorley
Copy link
Member

Many thanks for the PR!
This change will be in Neutrino 9 (when it is released) :-)

@patiboh
Copy link
Contributor Author

patiboh commented May 19, 2018

Great! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants