This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
create-project: Update webpack-cli from v2 to v3 #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We hadn't received a Renovate PR for this `webpack-cli` release (which would have reminded us to bump the version in `matrix.js`), since the dependency is intentionally not listed in `peerDependencies` so that people can install their own choice of CLI if desired. To prevent this problem in the future, `webpack-cli` has now been added to the monorepo `devDependencies`, so we'll get the reminder PR next time. webpack/webpack-cli@v2.1.5...v.3.1.0
|
It's worth noting as well that webpack-command is no longer recommended and likely to be archived soon (see webpack/webpack#7966) - and so us sticking with webpack-cli (but not blocking people trying others) seems like the best approach for us for now. |
eliperelman
approved these changes
Aug 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hadn't received a Renovate PR for this
webpack-clirelease (which would have reminded us to bump the version inmatrix.js), since the dependency is intentionally not listed inpeerDependenciesso that people can install their own choice of CLI if desired. To prevent this problem in the future,webpack-clihas now been added to the monorepodevDependencies, so we'll get the reminder PR next time.webpack/webpack-cli@v2.1.5...v.3.1.0