This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 214
Migration guide for v8 to v9 #1098
Merged
eliperelman
merged 4 commits into
neutrinojs:master
from
eliperelman:v9-migration-guide
Sep 17, 2018
Merged
Migration guide for v8 to v9 #1098
eliperelman
merged 4 commits into
neutrinojs:master
from
eliperelman:v9-migration-guide
Sep 17, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
suggested changes
Sep 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for putting this together! :-)
OK, I think this is now updated from the review. |
edmorley
reviewed
Sep 17, 2018
edmorley
reviewed
Sep 17, 2018
edmorley
approved these changes
Sep 17, 2018
docs/migration-guide.md
Outdated
@@ -45,7 +297,7 @@ module.exports = Neutrino({ root: __dirname }) | |||
.call('eslintrc'); | |||
``` | |||
|
|||
- **BREAKING CHANGE** When building, `file-loader` and `url-loader` will generate file names with pattern | |||
- **BREAKING CHANGE** When building, file-loader and url-loader will generate file names with pattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert this change to the v7->v8 migration section? :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #944.
Work in progress.