Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Migration guide for v8 to v9 #1098

Merged
merged 4 commits into from
Sep 17, 2018

Conversation

eliperelman
Copy link
Member

Fixes #944.

Work in progress.

@eliperelman eliperelman added this to the v9 milestone Sep 13, 2018
@eliperelman eliperelman self-assigned this Sep 13, 2018
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for putting this together! :-)

docs/migration-guide.md Outdated Show resolved Hide resolved
docs/migration-guide.md Outdated Show resolved Hide resolved
docs/migration-guide.md Outdated Show resolved Hide resolved
docs/migration-guide.md Outdated Show resolved Hide resolved
docs/migration-guide.md Outdated Show resolved Hide resolved
docs/migration-guide.md Outdated Show resolved Hide resolved
docs/migration-guide.md Outdated Show resolved Hide resolved
docs/migration-guide.md Outdated Show resolved Hide resolved
docs/migration-guide.md Outdated Show resolved Hide resolved
docs/migration-guide.md Show resolved Hide resolved
@eliperelman
Copy link
Member Author

OK, I think this is now updated from the review.

docs/migration-guide.md Outdated Show resolved Hide resolved
docs/migration-guide.md Outdated Show resolved Hide resolved
@@ -45,7 +297,7 @@ module.exports = Neutrino({ root: __dirname })
.call('eslintrc');
```

- **BREAKING CHANGE** When building, `file-loader` and `url-loader` will generate file names with pattern
- **BREAKING CHANGE** When building, file-loader and url-loader will generate file names with pattern
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert this change to the v7->v8 migration section? :-)

@eliperelman eliperelman merged commit c87d925 into neutrinojs:master Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants