This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
react: Use the react-hot-loader Babel plugin in production too #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`react-hot-loader` internally uses `process.env.NODE_ENV` conditionals to make most of its functionality a no-op when in production. Previously the production Babel plugin was a no-op too, however after gaearon/react-hot-loader#1081 and gaearon/react-hot-loader#1093 it now replaces instances of `hot(module)(App)` with `App`. In addition to removing a few lines of RHL code, this allows webpack to now perform its module concatenation optimization, and avoids Content-Security-Policy script-src `unsafe-eval` false positives. This change is compatible with all versions of RHL 4, however to see the benefit, users will need to upgrade to >=4.4.0 (in beta).
helfi92
approved these changes
Nov 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-hot-loaderinternally usesprocess.env.NODE_ENVconditionals to make most of its functionality a no-op when in production.Previously the production Babel plugin was a no-op too, however after gaearon/react-hot-loader#1081 and gaearon/react-hot-loader#1093 it now replaces instances of
hot(module)(App)withApp.In addition to removing a few lines of RHL code, this allows webpack to now perform its module concatenation optimization, and avoids Content-Security-Policy script-src
unsafe-evalfalse positives.This change is compatible with all versions of RHL 4, however to see the benefit, users will need to upgrade to >=4.4.0 (in beta).