Consider case when 'core-js' is located in 'babel-polyfill' root #181
Conversation
constgen
changed the title
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
=======================================
Coverage 93.43% 93.43%
=======================================
Files 36 36
Lines 518 518
=======================================
Hits 484 484
Misses 34 34
Continue to review full report at Codecov.
|
| @@ -99,6 +99,10 @@ module.exports = (neutrino) => { | |||
| .chunkFilename('[id].[chunkhash].js') | |||
| .end() | |||
| .resolve | |||
| .alias | |||
There was a problem hiding this comment.
Indent this line 2 more spaces.
| @@ -99,6 +99,10 @@ module.exports = (neutrino) => { | |||
| .chunkFilename('[id].[chunkhash].js') | |||
| .end() | |||
| .resolve | |||
| .alias | |||
| // TIP: make sure 2 version of "core-js" always match in package.json and babel-polyfill/package.json | |||
There was a problem hiding this comment.
- We can remove the "TIP" word here
- Capitalize "make" to "Make"
- Replace "version" with "versions"
There was a problem hiding this comment.
Yes. I thought what is the best here. "Make sure 2 versions of "core-js" always match in package.json and babel-polyfill/package.json" sounds like the next line of code do this. But it actually not. This comment should play a role of a reminder.
| @@ -99,6 +99,10 @@ module.exports = (neutrino) => { | |||
| .chunkFilename('[id].[chunkhash].js') | |||
| .end() | |||
| .resolve | |||
| .alias | |||
| // TIP: make sure 2 version of "core-js" always match in package.json and babel-polyfill/package.json | |||
| .set('core-js', join(require.resolve('core-js'), '..')) | |||
There was a problem hiding this comment.
Instead of a join with .., let's use dirname from path:
const { join, dirname } = require('path');
// ...
.set('core-js', dirname(require.resolve('core-js')))There was a problem hiding this comment.
Agree. Should think of this from the very beginning.
This change fixes situation when there are more than one 'core-js' library versions in the project. In this case 'babel-polyfill' downloads its verison to '/node_modules/babel-polyfill/node_modules/core-js'. That means
babel-preset-envcan't correctly resolve paths to 'core-js' when processimport 'babel-polyfill'. Babel will try to find it in '/node_modules/core-js' where the wrong version will be located.There is a particular project example when build fails because of core-js@1.x.x in the root node_modules and core-js@2.x.x in the babel-polyfill
This fix also expects that babel-polyfill structure is '/libs/index.js'. Hope it will not be changed.