Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Throw more useful errors when missing commands #393

Merged
merged 2 commits into from
Oct 30, 2017
Merged

Throw more useful errors when missing commands #393

merged 2 commits into from
Oct 30, 2017

Conversation

eliperelman
Copy link
Member

Fixes #390.

@eliperelman eliperelman requested a review from a team October 30, 2017 00:02
edmorley
edmorley reviewed Oct 30, 2017
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test for this?

@eliperelman
Copy link
Member Author

Ooo good idea.

@eliperelman
Copy link
Member Author

Added tests for run() and call() with non-registered commands.

@eliperelman eliperelman requested a review from a team October 30, 2017 00:53
edmorley
edmorley approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@eliperelman eliperelman merged commit 36ac6f8 into neutrinojs:master Oct 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliperelman @edmorley