Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Make --debug increase karma's logLevel from info to debug #394

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Make --debug increase karma's logLevel from info to debug #394

merged 1 commit into from
Oct 30, 2017

Conversation

@edmorley edmorley self-assigned this Oct 30, 2017
@edmorley
Copy link
Member Author

So the extra output for this PR is a bit more than some of the others, however I think that's ok, since it only affects the test command, and is likely exactly what the user would expect after running neutrino test --debug.

@edmorley edmorley mentioned this pull request Oct 30, 2017
8 tasks
Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect. Also, I don't mind output being verbose when using a debug flag, and I hope that is implied. ++

@edmorley
Copy link
Member Author

Agreed - I've just been keeping an eye on what the output difference is after my first go at the eslint part to this resulted in tens of thousands of lines of output 😆

@edmorley edmorley merged commit 84d4501 into neutrinojs:master Oct 30, 2017
@edmorley edmorley deleted the debug-karma branch October 30, 2017 00:35
@eliperelman
Copy link
Member

@edmorley haha yeah, I've made that mistake before. 😆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants