This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Stop using the fast-async babel plugin #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since: * The default Neutrino-supported browsers (last two versions of Chrome, Firefox, Edge, Opera, Safari & iOS) all support async natively: https://caniuse.com/#feat=async-functions * The same applies to Node 8+ (and Neutrino 9 is dropping support for Node 6): http://node.green/#ES2017-features-async-functions * Neutrino 9 final will be released with Babel 7, which will likely include built-in support for the fast-async plugin anyway: babel/babel#7076 * It's another dependency to cause possible regressions, eg: MatAtBread/fast-async#53 Fixes #741.
edmorley
added a commit
that referenced
this pull request
Apr 16, 2018
The `fast-async` version was pinned in 2edc81a to work around: MatAtBread/fast-async#53 That issue was fixed in fast-async v6.3.4, so it's safe to revert back to a tilde range again. This only needs applying to the v8 branch, since the version was not pinned on master (and #790 is about to remove fast-async there).
edmorley
added a commit
that referenced
this pull request
Sep 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since:
https://caniuse.com/#feat=async-functions
http://node.green/#ES2017-features-async-functions
Implement transform-async-to-promises babel/babel#7076
[Bug] 6.3.2 - Error: Cannot find module '@babel/helper-module-imports' MatAtBread/fast-async#53
Fixes #741.