Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Extract css without contenthash by default (react-components preset) #810

Merged
merged 2 commits into from
Apr 23, 2018
Merged

Extract css without contenthash by default (react-components preset) #810

merged 2 commits into from
Apr 23, 2018

Conversation

Didericis
Copy link
Contributor

Changes the default options for styles so that the content hash isn't included in filenames when css is extracted. This makes stylesheets easier to import.

EX:

// BEFORE
import 'my-component/build/MyComponent.qwerihqwenoasidf.css'
// AFTER
import 'my-component/build/MyComponent.css'

@Didericis Didericis changed the title Extract css without contenthash by default Extract css without contenthash by default (react-components preset) Apr 22, 2018
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good spot!

Looks fine to me - @eliperelman, do you agree? (This seems like the right place to set it, rather than adding yet another option in style-loader). Also should we backport to 8.x too?

@edmorley edmorley requested a review from eliperelman April 22, 2018 12:18
Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@eliperelman
Copy link
Member

Yeah, we should probably port to v8 if we can.

@edmorley edmorley merged commit 6732354 into neutrinojs:master Apr 23, 2018
@edmorley
Copy link
Member

This has just been released in v8.2.3 :-)

@edmorley edmorley added the bug label Jul 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants