This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
eslint: Throw if preset used after compile rule already defined #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presets such as `@neutrinojs/web` and `@neutrinojs/react` check to see if a `lint` rule is defined, and if so, adapt its settings to suit the particular environment/framework. This means that the lint presets must be defined prior to the compile presets or the final eslint configuration will not be correct. However previously this broken ordering would not result in an error message, causing confusion when eslint wasn't behaving as expected. Fixes #800. Refs #763.
eliperelman
approved these changes
Jun 7, 2018
This was referenced Jun 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presets such as
@neutrinojs/weband@neutrinojs/reactcheck to see if alintrule is defined, and if so, adapt its settings to suit the particular environment/framework. This means that the lint presets must be defined prior to the compile presets or the final eslint configuration will not be correct.Previously if the ordering was incorrect there would be no error message, causing confusion when eslint wasn't behaving as expected.
Fixes #800.
Refs #763.