This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Update dependency eslint-config-airbnb to v17 #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/eslint-config-airbnb-17.x
branch
from
5780db3 to
28e031e
Compare
PR has been editedAs this PR has been edited, Renovate will stop updating it in order to not cause any conflicts or other problems. If you wish to abandon your edits and have Renovate recreate this PR then you should rename this PR and then close it. |
To match airbnb-config's peer dependency, and since it actually
needs features only available on the newer versions.
Fixes:
```
node_modules/eslint-config-airbnb/rules/react.js:
Configuration for rule "react/jsx-no-target-blank" is invalid:
Value [{"enforceDynamicLinks":"always"}] should NOT have more than 0 items.
```
```
packages/create-project/commands/init/index.js
40:12 error Unnecessary 'else' after 'return' no-else-return
packages/create-project/commands/init/templates/preact/src/App.jsx
12:13 error `Welcome to ` must be placed on a new line react/jsx-one-expression-per-line
12:24 error `{this.state.name}` must be placed on a new line react/jsx-one-expression-per-line
12:25 error Must use destructuring state assignment react/destructuring-assignment
packages/create-project/commands/init/templates/react-components/src/components/HelloWorld/index.jsx
20:12 error Must use destructuring props assignment react/destructuring-assignment
24:26 error Must use destructuring props assignment react/destructuring-assignment
38:29 error Must use destructuring state assignment react/destructuring-assignment
38:66 error `Hello World!` must be placed on a new line react/jsx-one-expression-per-line
39:9 error Missing an explicit type attribute for button react/button-has-type
39:44 error `Change color` must be placed on a new line react/jsx-one-expression-per-line
packages/create-project/commands/init/templates/react/src/App.jsx
13:13 error `Welcome to ` must be placed on a new line react/jsx-one-expression-per-line
13:24 error `{this.state.name}` must be placed on a new line react/jsx-one-expression-per-line
13:25 error Must use destructuring state assignment react/destructuring-assignment
```
The `componentWillReceiveProps` usage was removed since its use is
now discouraged, and the behaviour of not letting new props override
current state seems fine. See:
https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops
edmorley
force-pushed
the
renovate/eslint-config-airbnb-17.x
branch
from
0c64381 to
1a177fe
Compare
eliperelman
approved these changes
Jun 25, 2018
| @@ -37,7 +37,8 @@ module.exports = class Project extends Generator { | |||
| title: this.options.name | |||
| } | |||
| }]; | |||
| } else if (projectType === 'library') { | |||
| } | |||
| if (projectType === 'library') { | |||
There was a problem hiding this comment.
nit: Insert a blank line above this conditional.
| return ( | ||
| <div class="App"> | ||
| <h1>Welcome to {this.state.name}</h1> | ||
| <h1> |
There was a problem hiding this comment.
Why did this have to be changed?
There was a problem hiding this comment.
Why did this have to be changed?
The eslint errors that were being fixed are listed in the commit message
There was a problem hiding this comment.
The "expression on a new line" change here looks a little redundant, but I guess there are other cases where it would help. It may be that eslint-config-prettier soon turns this off or something, but we can always adjust it back when/if we use prettier in this repo :-)
acconrad
pushed a commit
to acconrad/neutrino-dev
that referenced
this pull request
Jul 13, 2018
* Update dependency eslint-config-airbnb to v17
* Bump minimum eslint-plugin-{import,react}
To match airbnb-config's peer dependency, and since it actually
needs features only available on the newer versions.
Fixes:
```
node_modules/eslint-config-airbnb/rules/react.js:
Configuration for rule "react/jsx-no-target-blank" is invalid:
Value [{"enforceDynamicLinks":"always"}] should NOT have more than 0 items.
```
* Fix new eslint errors
```
packages/create-project/commands/init/index.js
40:12 error Unnecessary 'else' after 'return' no-else-return
packages/create-project/commands/init/templates/preact/src/App.jsx
12:13 error `Welcome to ` must be placed on a new line react/jsx-one-expression-per-line
12:24 error `{this.state.name}` must be placed on a new line react/jsx-one-expression-per-line
12:25 error Must use destructuring state assignment react/destructuring-assignment
packages/create-project/commands/init/templates/react-components/src/components/HelloWorld/index.jsx
20:12 error Must use destructuring props assignment react/destructuring-assignment
24:26 error Must use destructuring props assignment react/destructuring-assignment
38:29 error Must use destructuring state assignment react/destructuring-assignment
38:66 error `Hello World!` must be placed on a new line react/jsx-one-expression-per-line
39:9 error Missing an explicit type attribute for button react/button-has-type
39:44 error `Change color` must be placed on a new line react/jsx-one-expression-per-line
packages/create-project/commands/init/templates/react/src/App.jsx
13:13 error `Welcome to ` must be placed on a new line react/jsx-one-expression-per-line
13:24 error `{this.state.name}` must be placed on a new line react/jsx-one-expression-per-line
13:25 error Must use destructuring state assignment react/destructuring-assignment
```
The `componentWillReceiveProps` usage was removed since its use is
now discouraged, and the behaviour of not letting new props override
current state seems fine. See:
https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates dependency eslint-config-airbnb from
^16.1.0to^17.0.0Release Notes
v17.0.0Compare Source
This PR has been generated by Renovate Bot.