Disable some auto-add hardware features #241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses neutrinolabs/xrdp#2379 and neutrinolabs/xrdp#2253.
On some systems, GPUs are auto-loaded. These can be incompatible with the xorgxrdp module.
These keywords are not used by us yet, so I've done a quick analysis of contemporary systems. The reason is that these can cause errors on systems which don't expect them.
The
AutoAddGPU
keyword was introduced for xorg 1.13.0. This is no longer used by any contemporary systems.The GPUDevice keyword was introduced for xorg 1.18.0. This is still used by Ubuntu 16.04 which is technically still supported if you have an ESM contract with Canonical.
Our other long-term enterprise system, RHEL 7, uses Xorg 1.20.
I'm marking this draft for now, as I want to test on Ubuntu 16 and CentOS 7.
@akarl10 - do you have any comments on this PR? I'm pretty sure it's what we've discussed recently.