Fix freetype2 version checking #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of freetype2 returned by pkg-config --modversion is not the same as the product release version. Consequently, the check for version >= 2.8.0 does not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of freetype2 returned by
pkg-config --modversionis not the same as the freetype2 release version - more information here.Consequently, the existing autoconfigure check for version >= 2.8.0 does not work.
This version was chosen as 2.8.x was the easiest early one to test on - Ubuntu 18.04 uses 2.8.1 and CentOS 7 uses 2.8.14.
I've just discovered the check doesn't work for Ubuntu 16.04 which only has version 2.6.1 of libfreetype6. Without this PR, the configure step works fine but the compilation fails. The failure is due to a change made in version 2.6.3 relating to removing identifiers with double underscores '__'.
With this PR, the following error is generated on Ubuntu 16.04 if
--with-freetype2is used:-Omitting
--with-freetype2from the configure simply means that the new font generation utilityxrdp-mkfv1will not be available.