Neutrinordp sidebutton click #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt335672
added a commit
to matt335672/xrdp
that referenced
this pull request
Jan 25, 2024
FreeRDP silently redefines WM_LBUTTONUP, WM_LBUTTONDOWN, WM_RBUTTONUP and WM_RBUTTONDOWN. This fixes a regression introduced by neutrinolabs#2864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #2860 to devel
As well as @naruhito's cherry-picked commit, I've added a further commit removing the magic numbers from the module interface.
There's an actual value change here - the magic number 0x5555 (now
WM_MODULE_DATA) has been replaced with the value 201. However, 0x5555 is still used by libxrdp to callback into xrdp with the actual module channel data. I've left that change for another day as it's more complex.