Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFX: selectable lossy compression levels #2973

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

metalefty
Copy link
Member

@metalefty metalefty commented Feb 29, 2024

Reboot of #2539. This feature is also requested by @unstabler and another enterprise user.

Classic RemoteFX requires connectionType==LAN so we can't use the parameter to adjust compression level. In contrast, GFX can be used whatever value connectionType is set to. Therefore, we can use this parameter to tell the encoder compression level.

This is still a proof of concept so this PR is a draft.

Ultra Low Quality

image

Low Quality

image

Standard Quality

image

@metalefty metalefty mentioned this pull request Jul 11, 2024
3 tasks
@metalefty
Copy link
Member Author

There is room to adjust quantization values but this one can be merged.

@metalefty metalefty marked this pull request as ready for review July 24, 2024 15:36
@jsorg71
Copy link
Contributor

jsorg71 commented Jul 24, 2024

This looks good to me, maybe a rebase first.
As an expansion later maybe we can read these from xrdp.ini.

@metalefty metalefty merged commit ecebe45 into neutrinolabs:devel Jul 30, 2024
13 checks passed
@metalefty metalefty deleted the compression-level-options branch July 30, 2024 01:22
@metalefty metalefty mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants