gfx send multiple wire to surface messages when compressed data is la… #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rger than max_compressed_bytes
matt335672
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
I'm happy with this.
I've tested with @metalefty's test program in #2968 in a single (emulated) 4K monitor. I was unable to crash it.
I also re-tested running under valgrind, and got no memory violations.
|
I'm going to merge this into @metalefty - it's up to you whether you want to back-port this to v0.10.x, or leave that one with the version that's undergone user-acceptance testing. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rger than max_compressed_bytes