Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate from xyk to cl pools #69

Merged
merged 29 commits into from
Sep 5, 2023
Merged

migrate from xyk to cl pools #69

merged 29 commits into from
Sep 5, 2023

Conversation

sotnikov-s
Copy link
Contributor

@sotnikov-s sotnikov-s commented Jun 7, 2023 •
edited
Loading

tasks:

this PR:

  • introduces xyk->CL migration strategy for the reserve contract via exec messages which perform withdraw_liquidity + provide_liquidity with a given amounts and slippage tolerance.

related PRs:

@sotnikov-s sotnikov-s marked this pull request as ready for review June 16, 2023 09:40
@sotnikov-s sotnikov-s marked this pull request as draft June 16, 2023 09:43
@sotnikov-s sotnikov-s marked this pull request as ready for review June 20, 2023 09:22
@sotnikov-s
Copy link
Contributor Author

https://github.com/neutron-org/neutron-tests/actions/runs/5320356880

@sotnikov-s sotnikov-s mentioned this pull request Jun 20, 2023
Closed
albertandrejev
albertandrejev reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@albertandrejev albertandrejev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to implement tests for this migrations?

@sotnikov-s
Copy link
Contributor Author

Is it possible to implement tests for this migrations?

there are tests. see the link to the integration tests repo in the PR description

swelf19
swelf19 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@swelf19 swelf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about emitting some events

@sotnikov-s
Copy link
Contributor Author

https://github.com/neutron-org/neutron-tests/actions/runs/5786838812

@pr0n00gler pr0n00gler changed the base branch from main to neutron_audit_informal_04_09_2023 September 5, 2023 14:02
@pr0n00gler pr0n00gler merged commit 83b7733 into neutron_audit_informal_04_09_2023 Sep 5, 2023
@pr0n00gler pr0n00gler mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swelf19 swelf19 swelf19 approved these changes

@pr0n00gler pr0n00gler pr0n00gler approved these changes

@albertandrejev albertandrejev albertandrejev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sotnikov-s @albertandrejev @pr0n00gler @swelf19 @quasisamurai