You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You use main of the integration-tests repo in your test run, but you should use feat/xyk-to-cl-migration since the PR is related to the migration of liquidity
The reason will be displayed to describe this comment to others. Learn more.
It's out of scope, but since you've updated the reserve contract, please add similar CONTRACT_NAME and CONTRACT_VERSION constants into the distribution contract (and cw2 methods for setting contract info)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task: https://hadronlabs.atlassian.net/browse/NTRN-127
this PR:
set_contract_versionfor the reserve and distribution contracts;execute_migrate_from_xyk_to_cl.D.O.D. 6 from the task has been skipped due to majority is opposed to it.