Update our tokenfactory to the latest version NTRN-93 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2023
sotnikov-s
requested changes
Sep 12, 2023
| denom, | ||
| }, | ||
| }); | ||
| expect(res.cosm_wasm_addr).toEqual(contractAddress); |
There was a problem hiding this comment.
I'd really like to see at least a small test case which assures we can not only set contracts for hooks, but also the hooks actually work
There was a problem hiding this comment.
I'd like too, but it's gonna require implementation of the whole contract w custom logic (and we don't want to waste any more time). so:
- code of whole module is copypasted
- module integrated successfully
- the test will be more about contract written for this test
- time pressure
NeverHappened
requested changes
Sep 18, 2023
|
https://github.com/neutron-org/neutron-tests/actions/runs/6173587028/job/16939576523 actually test are passing |
|
yeah, I have last tests passing now https://github.com/neutron-org/neutron-tests/actions/runs/6238607927 |
sotnikov-s
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task