-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add possibility for unordered ica channels #ntrn-376 #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeverHappened
force-pushed
the
feat/unordered-ica
branch
from
August 14, 2024 21:25
2493c19
to
8d16d3b
Compare
This was referenced Aug 15, 2024
NeverHappened
changed the title
feat: unordered ICA channels
feat: add possibility for unordered ica channels #ntrn-376
Aug 16, 2024
swelf19
approved these changes
Sep 2, 2024
joldie777
approved these changes
Sep 2, 2024
pr0n00gler
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hadronlabs.atlassian.net/browse/NTRN-376
Now ICA accounts can be with unordered channels.
They do not close after timeout. And messages be delivered in random order.
PR's: