Rework governance/ update admin-module NTRN-70 (sdk-47) #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasisamurai
changed the title
This was referenced Aug 17, 2023
quasisamurai
force-pushed
the
feat/sdk47
branch
from
2a7f2c8 to
a472255
Compare
quasisamurai
force-pushed
the
feat/sdk47
branch
from
f572826 to
157f63d
Compare
quasisamurai
changed the title
quasisamurai
changed the title
pr0n00gler
approved these changes
Aug 25, 2023
swelf19
approved these changes
Aug 30, 2023
sotnikov-s
approved these changes
Aug 30, 2023
| admin_proposal: AdminProposal::CancelSoftwareUpgradeProposal(proposal), | ||
| } | ||
| } | ||
|
|
||
| /// Basic helper to define a parameter change proposal passed to AdminModule: |
There was a problem hiding this comment.
please update comments for submit_upgrade_proposal and for submit_client_update_proposal — they still claim that those are helpers for parameter change proposals creation
| pub contract: String, | ||
| /// ProposalExecuteMessage defines the struct for sdk47 compatible update params admin proposal. | ||
| pub struct ProposalExecuteMessage { | ||
| /// **message** is a json representing a sdk message passed to admin module to execute. |
There was a problem hiding this comment.
Suggested change
| /// **message** is a json representing a sdk message passed to admin module to execute. | |
| /// **message** is a json representing an sdk message passed to admin module to execute. |
NeverHappened
approved these changes
Aug 31, 2023
quasisamurai
force-pushed
the
feat/sdk47
branch
from
9222c99 to
756a026
Compare
pr0n00gler
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK
Admin module PR
Neutron PR
Neutron SDK PR
Integration tests