feat: tooling for tests about malformed kv queries #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratik
changed the base branch from
main
to
neutron_audit_oak_19_09_2022_fixes
ratik
force-pushed
the
feat/kv-query-keys-validation
branch
from
3cbf7f0 to
6e53c44
Compare
foxpy
approved these changes
Oct 19, 2022
|
Can you add more description please? It helps a lot to be in context with good description. |
|
tbh I found it very dangerous to have test specific code inside contract especially if this code can change behavior of the sudo handler. It may lead to unpredictable security flaws. |
| @@ -36,6 +36,18 @@ pub enum ExecuteMsg { | |||
| query_id: u64, | |||
| }, | |||
| /// Used only in integration tests framework to simulate failures. | |||
There was a problem hiding this comment.
Can you add more descriptive comment for this and following methods please?
There was a problem hiding this comment.
ok, I've added more detailed description
…on-org/neutron-contracts into feat/kv-query-keys-validation
…on-org/neutron-contracts into feat/kv-query-keys-validation
zavgorodnii
previously approved these changes
Nov 3, 2022
…on-org/neutron-contracts into feat/kv-query-keys-validation
…on-org/neutron-contracts into feat/kv-query-keys-validation
…on-org/neutron-contracts into feat/kv-query-keys-validation
zavgorodnii
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked PR: neutron-org/neutron#78
integration tests: neutron-org/neutron-integration-tests#34