-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vesting managed #20
Merged
zavgorodnii
merged 14 commits into
feat/vesting-and-vault-interface
from
feat/vesting-managed
Mar 28, 2023
Merged
feat: vesting managed #20
zavgorodnii
merged 14 commits into
feat/vesting-and-vault-interface
from
feat/vesting-managed
Mar 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr0n00gler
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks legit
oldremez
approved these changes
Mar 27, 2023
…aged # Conflicts: # Cargo.lock # Cargo.toml # contracts/vesting-lp/src/tests/integration.rs
…aged # Conflicts: # packages/astroport/src/vesting.rs # packages/vesting-base/src/contract.rs
sotnikov-s
reviewed
Mar 27, 2023
foxpy
reviewed
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a README.md for vesting-managed wouldn't hurt.
sotnikov-s
reviewed
Mar 28, 2023
zavgorodnii
force-pushed
the
feat/vesting-managed
branch
from
March 28, 2023 10:44
0b55b19
to
80ad747
Compare
…aged # Conflicts: # packages/astroport/src/vesting.rs
sotnikov-s
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a version of the vesting contract that allows the owner to delete existing vesting schedules for a given user.
The only addition to the astroport base besting contract is the
remove_vesting_accounts()
function:neutron-tge-contracts/contracts/vesting-managed/src/contract.rs
Line 131 in 08f19f0
For each vesting account, we calculate the amount of tokens to claw back (unclaimed + still vesting), remove the vesting information from the storage, and update the
total_granted
,total_released
metrics.No neutron integration tests were implemented because I was able to write "integration" tests in the unit tests:
neutron-tge-contracts/contracts/vesting-managed/src/tests/integration.rs
Line 885 in aa9e164