Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vesting managed #20

Merged
merged 14 commits into from
Mar 28, 2023

Conversation

zavgorodnii
Copy link
Contributor

@zavgorodnii zavgorodnii commented Mar 22, 2023

This PR adds a version of the vesting contract that allows the owner to delete existing vesting schedules for a given user.

The only addition to the astroport base besting contract is the remove_vesting_accounts() function:

For each vesting account, we calculate the amount of tokens to claw back (unclaimed + still vesting), remove the vesting information from the storage, and update the total_granted, total_released metrics.

No neutron integration tests were implemented because I was able to write "integration" tests in the unit tests:

@zavgorodnii zavgorodnii marked this pull request as ready for review March 23, 2023 11:54
Copy link
Collaborator

@pr0n00gler pr0n00gler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

Andrei Zavgorodnii added 3 commits March 27, 2023 15:56
…aged

# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	contracts/vesting-lp/src/tests/integration.rs
…aged

# Conflicts:
#	packages/astroport/src/vesting.rs
#	packages/vesting-base/src/contract.rs
Copy link
Contributor

@foxpy foxpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a README.md for vesting-managed wouldn't hurt.

@zavgorodnii zavgorodnii force-pushed the feat/vesting-managed branch from 0b55b19 to 80ad747 Compare March 28, 2023 10:44
…aged

# Conflicts:
#	packages/astroport/src/vesting.rs
@zavgorodnii zavgorodnii merged commit b3a60e3 into feat/vesting-and-vault-interface Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants