[NTRN-483] fix: claim generator rewards #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr0n00gler
approved these changes
Jun 6, 2023
foxpy
reviewed
Jun 7, 2023
contracts/lockdrop/src/contract.rs
Outdated
| rwi.base_reward_token.to_string(), | ||
| )? | ||
| .amount; | ||
| base_reward_received = reward_token_balance - prev_ntrn_balance; |
There was a problem hiding this comment.
While we are here, let's use checked_sub to feel 🦀 extra safe 🦀?
There was a problem hiding this comment.
contract: becomes extra safe after single minus-to-checked_sub replacement
also contract: still has dozens of unsafe sub and sum operations
zavgorodnii
approved these changes
Jun 7, 2023
swelf19
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: https://p2pvalidator.atlassian.net/browse/NTRN-483
this PR:
motivation:
Generator's base reward token is a native astro token bridged via IBC, not a cw20 token. This cw20-based behaviour would broke user's claim calls to the lockdrop contract when generator is assigned a vesting account in the corresponding vesting contract.
related PRs: