return err on set params

neutron-org · Sep 16, 2024 · 81f6303 · 81f6303
1 parent 71477cc
commit 81f6303
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/x/ibc-rate-limit/genesis.go b/x/ibc-rate-limit/genesis.go
@@ -9,7 +9,10 @@ import (
 // InitGenesis initializes the x/ibc-rate-limit module's state from a provided genesis
 // state, which includes the parameter for the contract address.
 func (i *ICS4Wrapper) InitGenesis(ctx sdk.Context, genState types.GenesisState) {
-	i.SetParams(ctx, genState.Params)
+	err := i.IbcratelimitKeeper.SetParams(ctx, genState.Params)
+	if err != nil {
+		panic(err)
+	}
 }
 
 // ExportGenesis returns the x/ibc-rate-limit module's exported genesis.

diff --git a/x/ibc-rate-limit/ibc_middleware_test.go b/x/ibc-rate-limit/ibc_middleware_test.go
@@ -613,7 +613,7 @@ func (suite *MiddlewareTestSuite) InstantiateRLContract(quotas string) sdk.AccAd
 func (suite *MiddlewareTestSuite) RegisterRateLimitingContract(addr []byte) {
 	addrStr, _ := sdk.Bech32ifyAddressBytes("neutron", addr)
 	app := suite.GetNeutronZoneApp(suite.ChainA)
-	_ = app.RateLimitingICS4Wrapper.IbcratelimitKeeper.SetParams(suite.ChainA.GetContext(), types.Params{ContractAddress: addrStr})
+	_ = app.RateLimitingICS4Wrapper.SetParams(suite.ChainA.GetContext(), types.Params{ContractAddress: addrStr})
 	require.True(suite.ChainA.TB, true)
 }
 

diff --git a/x/ibc-rate-limit/ics4_wrapper.go b/x/ibc-rate-limit/ics4_wrapper.go
@@ -103,6 +103,6 @@ func (i *ICS4Wrapper) GetParams(ctx sdk.Context) (params types.Params) {
 	return params
 }
 
-func (i *ICS4Wrapper) SetParams(ctx sdk.Context, params types.Params) {
-	i.IbcratelimitKeeper.SetParams(ctx, params)
+func (i *ICS4Wrapper) SetParams(ctx sdk.Context, params types.Params) error {
+	return i.IbcratelimitKeeper.SetParams(ctx, params)
 }