Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccv msg filter build tag #227

Merged
merged 4 commits into from
Apr 30, 2023
Merged

ccv msg filter build tag #227

merged 4 commits into from
Apr 30, 2023

Conversation

oldremez
Copy link
Contributor

@oldremez oldremez commented Apr 30, 2023

This PR allows configuring if arbitrary messages should be disabled while the chain is not interchain-secured at built time.
The build tag "skip_ccv_msg_filter" being set to true disables message filtering for the test environment.

Passing tests show that disabling works properly (in the other case tests wouldn't pass).

To test if messages are filtered if the option is "false" or not even present in the config do the following:

  1. Comment the line 53 of Makefile (build_tags_test_binary += skip_ccv_msg_filter)
  2. Run the chain via make start
  3. Run the following command:
    neutrond tx bank send demowallet1 neutron1suhgf5svhu4usrurvxzlgn54ksxmn8gljarjtxqnapv8kjnp4nrstdxvff 1untrn --fees 125000untrn --keyring-backend test --home data/test-1 --chain-id test-1 -y -b block
    It should fail with raw_log: tx contains unsupported message types at height in the output.

@oldremez
Copy link
Contributor Author

@oldremez oldremez marked this pull request as ready for review April 30, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants