add basic registered query validation in genesis #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasisamurai
force-pushed
the
chore/registered-query-genesis-validation
branch
from
8166a7b to
aad302d
Compare
foxpy
requested changes
May 23, 2023
foxpy
previously approved these changes
May 23, 2023
sotnikov-s
requested changes
May 23, 2023
foxpy
previously approved these changes
May 26, 2023
pr0n00gler
reviewed
Jun 15, 2023
foxpy
previously approved these changes
Jun 30, 2023
pr0n00gler
previously approved these changes
Jun 30, 2023
sotnikov-s
requested changes
Jun 30, 2023
x/interchainqueries/genesis_test.go
Outdated
| interchainqueries.InitGenesis(ctx, *k, genesisState) | ||
| got := interchainqueries.ExportGenesis(ctx, *k) | ||
| err := got.Validate() | ||
| require.ErrorContains(t, err, "Invalid owner address") |
There was a problem hiding this comment.
why Invalid owner address if the test's name is TestGenesisMalformedQueriesNoKvKeys?
sotnikov-s
approved these changes
Jun 30, 2023
NeverHappened
requested changes
Jun 30, 2023
There was a problem hiding this comment.
I don't see implementation of this part of the task in changes:
Parms.Validate() returns nil insted of validation
|
@NeverHappened there is nothing to validate, basically. Every param has no limitations |
NeverHappened
approved these changes
Jul 17, 2023
pr0n00gler
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.