Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allowlist stargate queries #ntrn-547 #273

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

NeverHappened
Copy link
Contributor

@NeverHappened NeverHappened commented Jun 23, 2023

@NeverHappened NeverHappened self-assigned this Jun 23, 2023
@NeverHappened NeverHappened marked this pull request as draft June 23, 2023 14:14
@NeverHappened NeverHappened force-pushed the feat/allowlist-stargate-queries branch from 71fad65 to cc817e0 Compare June 26, 2023 09:23
@NeverHappened NeverHappened marked this pull request as ready for review July 3, 2023 11:15
Comment on lines 54 to 55
"/neutron.feeburner.Query/Params": &feeburnertypes.QueryParamsResponse{},
"/neutron.feeburner.Query/TotalBurnedNeutronsAmount": &feeburnertypes.QueryTotalBurnedNeutronsAmountResponse{},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have these queries in our bindings

@NeverHappened NeverHappened force-pushed the feat/allowlist-stargate-queries branch from e162e31 to f05fe22 Compare July 4, 2023 12:24
@NeverHappened NeverHappened force-pushed the feat/allowlist-stargate-queries branch from f05fe22 to 167b7b5 Compare July 4, 2023 12:25
Copy link
Contributor

@foxpy foxpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks decent, but I am hesitant to approve without any tests.

@NeverHappened
Copy link
Contributor Author

NeverHappened commented Jul 11, 2023

Integration tests run (see if passed): https://github.com/neutron-org/neutron-tests/actions/runs/5521339064

@NeverHappened
Copy link
Contributor Author

Looks decent, but I am hesitant to approve without any tests.

I added tests just now ! :)

@pr0n00gler pr0n00gler merged commit acc4691 into main Jul 31, 2023
@pr0n00gler pr0n00gler deleted the feat/allowlist-stargate-queries branch January 11, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants