-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allowlist stargate queries #ntrn-547 #273
Conversation
71fad65
to
cc817e0
Compare
wasmbinding/stargate_allowlist.go
Outdated
"/neutron.feeburner.Query/Params": &feeburnertypes.QueryParamsResponse{}, | ||
"/neutron.feeburner.Query/TotalBurnedNeutronsAmount": &feeburnertypes.QueryTotalBurnedNeutronsAmountResponse{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have these queries in our bindings
e162e31
to
f05fe22
Compare
f05fe22
to
167b7b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks decent, but I am hesitant to approve without any tests.
Integration tests run (see if passed): https://github.com/neutron-org/neutron-tests/actions/runs/5521339064 |
I added tests just now ! :) |
Implements https://p2pvalidator.atlassian.net/browse/NTRN-547
Integration tests: neutron-org/neutron-integration-tests#175
New contract for for new integration tests: neutron-org/neutron-dev-contracts#21