feat: set commit timeout #ntrn-79 #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeverHappened
force-pushed
the
feat/set-commit-timeout
branch
from
df9dae5 to
7291a85
Compare
pr0n00gler
requested changes
Jul 27, 2023
|
I think it's base branch issues, waiting to rebase on fix of them |
|
@NeverHappened you have merge conflicts by the way |
NeverHappened
force-pushed
the
feat/set-commit-timeout
branch
from
7291a85 to
6678a44
Compare
pr0n00gler
requested changes
Aug 3, 2023
cmd/neutrond/root.go
Outdated
| @@ -87,7 +88,14 @@ func NewRootCmd() (*cobra.Command, params.EncodingConfig) { | |||
| } | |||
|
|
|||
| customTemplate, customNeutronConfig := initAppConfig() | |||
| return server.InterceptConfigsPreRunHandler(cmd, customTemplate, customNeutronConfig, tmcfg.DefaultConfig()) | |||
| err = server.InterceptConfigsPreRunHandler(cmd, customTemplate, customNeutronConfig, tmcfg.DefaultConfig()) | |||
There was a problem hiding this comment.
You can just create our own DefaultConfig() instead of tmcfg.DefaultConfig() with timeout_commit = 5s
…ion of interceptConfig
pr0n00gler
approved these changes
Aug 7, 2023
swelf19
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hadronlabs.atlassian.net/browse/NTRN-79
checked only by printing in server config in cmd, it's hard to discover cometbft settings in runtime