feat: ictx + transfer with limited sudo call #NTRN-85 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swelf19
force-pushed
the
feat/icatx-rework
branch
from
509e332 to
0fb54fc
Compare
swelf19
changed the title
# Conflicts: # go.sum # network/init-neutrond.sh
pr0n00gler
requested changes
Aug 29, 2023
# Conflicts: # x/interchaintxs/keeper/ibc_handlers.go # x/interchaintxs/keeper/ibc_handlers_test.go # x/transfer/ibc_handlers.go # x/transfer/ibc_handlers_test.go
pr0n00gler
approved these changes
Aug 31, 2023
NeverHappened
requested changes
Aug 31, 2023
Co-authored-by: Dmitry Kolupaev <dmitry.klpv@gmail.com>
pr0n00gler
approved these changes
Sep 4, 2023
sotnikov-s
reviewed
Sep 5, 2023
|
also please:
|
|
feat: interachain sudo callback refactoring
# Conflicts: # app/app.go
sotnikov-s
approved these changes
Sep 20, 2023
pr0n00gler
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent malicious contract to overuse ibc sudo call, and run heavy computing at relayer's expense, we run sudo call with certain amount of gas(dao controlled) -
SudoCallLimitWe run sudo call with
cacheCtxwith limited amount of gas_, err = im.ContractManagerKeeper.SudoTimeout(cacheCtx, senderAddress, packet)If the contract tries to consume more gas than allowed with
SudoCallLimit, then panic is initiated bywasmvmWe converts the
out of gaspanic(and only this), and process it later as general error returned from the contract, i.e. suppress the error, save failure to the storage, pay fees to relayer.In case of any other kind of panic, we treat it as relayers fault, do not recover it. Transaction aborted.
test run: https://github.com/neutron-org/neutron-tests/actions/runs/5939595766