feat: add axlr reward denom #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeverHappened
changed the base branch from
main
to
feat/contract-manager-resubmit
pr0n00gler
requested changes
Aug 23, 2023
app/upgrades/nextupgrade/upgrades.go
Outdated
| var denoms []string | ||
| keepers.CcvConsumerSubspace.Get(ctx, ccvconsumertypes.KeyRewardDenoms, &denoms) | ||
|
|
||
| // add new denom |
There was a problem hiding this comment.
Please specify what denom is that exactly
pr0n00gler
requested changes
Aug 23, 2023
|
|
||
| suite.Require().True(ccvConsumerSubspace.Has(ctx, ccvconsumertypes.KeyRewardDenoms)) | ||
|
|
||
| var denomsBefore []string |
There was a problem hiding this comment.
There should be "ntrtn" actually, cause we have it on mainnet currently
pr0n00gler
approved these changes
Aug 23, 2023
swelf19
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: changed base branch to avoid merge conflicts in upgrades handler
https://hadronlabs.atlassian.net/browse/NTRN-87