fix: modify interchain keeper's accepted parameteres #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swelf19
approved these changes
Oct 25, 2023
pr0n00gler
approved these changes
Oct 26, 2023
sotnikov-s
requested changes
Oct 30, 2023
sotnikov-s
approved these changes
Nov 1, 2023
pr0n00gler
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following our discussion - let interchaintxs keeper accept a more generalized interface.
This way, other chains that reuse the interchaintxs module would not be required to also use feeburner module, instead
they can implement GetTreasury function in the module that maintains the treasury address for their chain and pass it
to the interchaintxs keeper.
cc @swelf19 @pr0n00gler