Remove incentives and epochs module. #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rationale is as follows: 1. No direct need to incentivize the base pools right away. Most of that is done on astroport and integrations 2. The modules were modified from Osmo incentives and the degree of certainty we have here (even after 2 audits) is not the same as the core Dex module. 3. Upside of incentives is low compared to risk of pushing sub-optimal code Given that I think we should hold off on the deployment of the incentives, keep it back here for a while longer for further testing etc and decide if we really want it in the future.
pr0n00gler
approved these changes
Nov 7, 2023
swelf19
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale is as follows:
Given that I think we should hold off on the deployment of the incentives, keep it back here for a while longer for further testing etc and decide if we really want it in the future.