Audit FIX: ibc swap pfm issues #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcompagni10
force-pushed
the
fix/ibc-_swap_pfm_issues
branch
from
3df350e to
b74d421
Compare
- Fix issues relating to PFMs new overrideReceiver address - Small cleanup up OnRecvPacket for greater clarity - Get rid of NonRefundable swap param and just use presence NeutronRefundAddress to determine refund behavior. - Improve refund behavior to allow for IBC refund after failed forward - Add additional validation to ensure that only the amount transfered is used for swap
jcompagni10
force-pushed
the
fix/ibc-_swap_pfm_issues
branch
from
b74d421 to
10ab425
Compare
pr0n00gler
reviewed
Nov 9, 2023
pr0n00gler
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade x/ibcswap to be compatible with PFM v7.0.2