Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: release #378

Merged
merged 1 commit into from
Nov 28, 2023
Merged

v2: release #378

merged 1 commit into from
Nov 28, 2023

Conversation

pr0n00gler
Copy link
Collaborator

No description provided.

Copy link
Contributor

@quasisamurai quasisamurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@sotnikov-s sotnikov-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to update pion-1 upgrade docs for validators correspondingly

@@ -21,9 +21,9 @@ import (
"github.com/neutron-org/neutron/docs"

"github.com/neutron-org/neutron/app/upgrades"
v030 "github.com/neutron-org/neutron/app/upgrades/v0.3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor suggestion: let's make this one and the rest as v0_3_0? otherwise it could be a little pain in the ass in the future when we have releases like 2.0.15 as 2015. we'd better stick with a more readable pattern for versions

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter doesn't like this

Copy link
Contributor

@NeverHappened NeverHappened left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! you didn't change the old upgrade names, so it should be fine right?just too make sure there is no repeated migrations because of the renames

@pr0n00gler pr0n00gler merged commit e605ed3 into main Nov 28, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants