Chore: better update fn naming #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcompagni10
force-pushed
the
chore/better_update_fn_naming
branch
2 times, most recently
from
6b6d06c to
1a50fc9
Compare
NicholasDotSol
previously approved these changes
Sep 25, 2024
swelf19
previously approved these changes
Oct 9, 2024
jcompagni10
dismissed stale reviews from swelf19 and NicholasDotSol
via
dc02518
pr0n00gler
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearer naming for update fns. This eliminates confusion about what the various functions used for updating KV store records do.
Note: because of PRs like this, that add additional event handlers to the save functions it is preferable to use a single update function, so that any future logic/event hooks only need to happen in one place.
UpdateLimitOrderTrancheUpdateLimitOrderTrancheUserUpdatePoolUpdatePoolReservesAlso, lots of extra comments and small refactoring so that each function is easier to understand.