Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/chainmanager globalfee dynamicfee ccv params #NTRN-408 #69

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

swelf19
Copy link
Contributor

@swelf19 swelf19 commented Nov 15, 2024

The PR adds a method for submiting proposals to change the parameters of the consumer module. The method for creating cron schedules via bindings has been corrected (the execution_stage argument was missed).

Task definition: Add updateParamsPersimmon to chain manager (https://github.com/neutron-org/neutron-dao/tree/main/contracts/dao/neutron-chain-manager) for the following modules:

  • consumer
  • dynamicfees
  • globalfee

All prs:
neutron-org/neutronjs#10
#69
neutron-org/neutron-integration-tests#368
neutron-org/neutron-dao#116
neutron-org/neutron-std#8
neutron-org/neutron#765

joldie777
joldie777 previously approved these changes Nov 20, 2024
src/proposal.ts Outdated
@@ -220,6 +220,47 @@ export type ConsensusParams = {
};
};

export type ConsumerParams = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why redefining if this struct is exportable from neutronjs src/interchain_security/ccv/v1/shared_consumer.ts?

@pr0n00gler pr0n00gler merged commit 3d1761a into main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants