-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/chainmanager globalfee dynamicfee ccv params #NTRN-408 #69
Merged
pr0n00gler
merged 5 commits into
main
from
feat/chainmanager-globalfee-dynamicfee-ccv-params
Nov 27, 2024
Merged
Feat/chainmanager globalfee dynamicfee ccv params #NTRN-408 #69
pr0n00gler
merged 5 commits into
main
from
feat/chainmanager-globalfee-dynamicfee-ccv-params
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2024
Merged
joldie777
previously approved these changes
Nov 20, 2024
sotnikov-s
reviewed
Nov 25, 2024
src/proposal.ts
Outdated
@@ -220,6 +220,47 @@ export type ConsensusParams = { | |||
}; | |||
}; | |||
|
|||
export type ConsumerParams = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why redefining if this struct is exportable from neutronjs
src/interchain_security/ccv/v1/shared_consumer.ts
?
NeverHappened
approved these changes
Nov 26, 2024
sotnikov-s
approved these changes
Nov 26, 2024
joldie777
approved these changes
Nov 27, 2024
pr0n00gler
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a method for submiting proposals to change the parameters of the
consumer
module. The method for creatingcron
schedules via bindings has been corrected (the execution_stage argument was missed).Task definition: Add updateParamsPersimmon to chain manager (https://github.com/neutron-org/neutron-dao/tree/main/contracts/dao/neutron-chain-manager) for the following modules:
All prs:
neutron-org/neutronjs#10
#69
neutron-org/neutron-integration-tests#368
neutron-org/neutron-dao#116
neutron-org/neutron-std#8
neutron-org/neutron#765