Skip to content

Commit

Permalink
Switch CI to use macos-latest runner
Browse files Browse the repository at this point in the history
GitHub Actions dropped support for macos-10.15 on 2022-12-01:
- actions/runner-images#5583

Under the presumption that MacOS is primarily used for development and
not for deployment, I've switched the macos GitHub Actions runners to
use the "latest" release version for ruby >= 2.6.  Earlier ruby's don't
support arm64, so they are using the macos-13 runner (which is amd64).

On the one hand, this is less explicit and is no longer "pinned", so it
may result in CI failing when GitHub Actions updates these runners.  On
the other hand, we also won't need another PR to update these every time
an old version is dropped or a new version is added.

I attempted to make the same change from windows-2019 to windows-latest.
But I saw three tests that reliably pass under windows-2019 and reliably
fail under windows-2022.  Since I don't have a Windows OS dev env at my
disposal, I'm opting to just let windows CI continue under windows-2019,
for now.
  • Loading branch information
nevans committed Sep 3, 2024
1 parent 6941226 commit 76310f3
Showing 1 changed file with 15 additions and 1 deletion.
16 changes: 15 additions & 1 deletion .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,27 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ ubuntu-24.04, ubuntu-22.04, ubuntu-20.04, macos-10.15, windows-2019 ]
os: [ ubuntu-24.04, ubuntu-22.04, ubuntu-20.04, windows-2019, macos-latest ]
ruby: [ '2.2', '2.3', '2.4', '2.5', '2.6', '2.7', '3.0', '3.1', head ]
include:
- { os: windows-2019, ruby: mingw }

# CRuby < 2.6 does not support macos-arm64, so these use amd64
- { os: macos-13, ruby: "2.2" }
- { os: macos-13, ruby: "2.3" }
- { os: macos-13, ruby: "2.4" }
- { os: macos-13, ruby: "2.5" }

exclude:
- { os: macos-latest, ruby: head }
- { os: windows-2019, ruby: head }

# CRuby < 2.6 does not support macos-arm64, so these use amd64
- { os: macos-latest, ruby: "2.2" }
- { os: macos-latest, ruby: "2.3" }
- { os: macos-latest, ruby: "2.4" }
- { os: macos-latest, ruby: "2.5" }

# Avoids the following error:
# Bundler 2 requires Ruby 2.3+, using Bundler 1 on Ruby <= 2.2
# /opt/hostedtoolcache/Ruby/2.2.10/x64/bin/gem install bundler -v ~> 1.0
Expand Down

0 comments on commit 76310f3

Please sign in to comment.