Newarch: add init() function #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: js/jquery.mapael.js
Indigo744
force-pushed
the
Indigo744-patch-newarch-init-2
branch
from
d371b05 to
f523484
Compare
Indigo744
force-pushed
the
Indigo744-patch-newarch-init-2
branch
from
48b4080 to
f523484
Compare
|
Thank you, not so much modifications in the diff tool actually ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new PR introduce a separation between the Mapael constructor and a new
init()function.Now that the constructor take less space, we can move all the members (
version,zoomTO,panningand so on...) on the top in order to trace them easily.Related to #117.
Note: the github diff tools shows a lots of modification. Actually, there wasn't so much. The updated indentation mess everything up again. I suggest you to go through each commit ;-)