New architecture: prototype pattern #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #117
This one is huge!
Now,
$.fn.mapael
is only a lightweight function wrapper to jquery to build a new object.$.mapael
is now an prototype object that is instanciated on an element.The constructor only init some internal variable and call
init()
.The main modification is that
this
shall be use to address the current mapael object (and notMapael
anymore!). You will see that I usually assignself
asthis
at the top of a function in order to avoid misleading name.For the next step, there are a lot of function that can be simplify due to being in an object. For instance, a lot of internal function make use of
$container
as parameter, whereas it could simply be accessible fromself.$container
. But this will make another PR. This one is already big :)