Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New arch: use $.mapael to get mapconf #151

Merged
merged 2 commits into from
Dec 2, 2015

Conversation

Indigo744
Copy link
Collaborator

As discussed in #117
Check both $.mapael and $.fn.mapael and warn the user if extending the later.

@neveldo
Copy link
Owner

neveldo commented Dec 1, 2015

Hello,

Thank you for your PR, I think that the previous check for the map should be removed at line 251 :

        if ($.fn[pluginName].maps[options.map.name] === undefined) {
            throw Error("Unknown map '" + options.map.name + "'");
        }

@Indigo744
Copy link
Collaborator Author

Right, this is corrected :)

neveldo added a commit that referenced this pull request Dec 2, 2015
New arch: use $.mapael to get mapconf
@neveldo neveldo merged commit 1ac36c7 into neveldo:master Dec 2, 2015
@Indigo744 Indigo744 deleted the Indigo744-patch-mapconf branch December 2, 2015 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants