-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand zoom buttons functionality #167
Conversation
015566e
to
45f7407
Compare
.html(opt.content) | ||
.attr("title", opt.title); | ||
// Assign click event | ||
$button.on("click." + pluginName, fnZoomButtons[type]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if a user add a button "myCustomButton" in the conf ? Maybe we should check for fnZoomButtons[type] existence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea indeed.
Moreover, should we allow the user to add custom buttons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering it too :) Maybe I'm wrong but I don't think it will be a common need to add custom zoom buttons. Moreover, the user will still can add custom buttons freely, without using mapael conf.
Thank you for this new feature :) Maybe the UPGRADE.md should be updated regarding the replacement zoomInCssClass and zoomOutCssClass ? |
Done :) |
Thank you :) |
Expand zoom buttons functionality
Implements #166 and add some customization to zoom buttons !
The default options now looks like this: for each buttons, a cssClass, content and title is provided.
Note: at the beginning, I though about adding a complete HTML tooltip like in the map, but title attribute was quite sufficient for this task.