-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Genericify refactor #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing, just a few minor comments.
Decision: to remove regions from the app, these can be added as a new feature so the code has been left in place but is not used. |
9f4fed3
to
c8d1ee8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
DO NOT MERGE NOT COMPLETE!
This PR contains a refactor of some of the configuration and functionality moving it from hard coded config/javascript to config options with the intention to make it easier to deploy and use across multiple dashboards.
Main changes include:
TODO: