Feat heat map bugs fixes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses these identified issues from the heatmap refactor:
1.Default rounding issues
Rounding on the icon value is failing (only when when time window is adjusted) I think its just the default value for precision not being honored. This also affects tooltip values. Its ok if the precision is specified.
Aggregated markers
values don’t update on auto-update (pre-existing issue)
Value as string
If value is a string then we get an error with toFixed. Forcing the value to numeric in the query fixes but better if code dealt with it?
Back slashes in nrql
Back slashes in the query cause a graphql error, You have to double escape (like the query above ^) . Better if app dealt with this? (pre-existing bug)
Missing lat/lng
If markers query lack lat/lng columns an error occurs (pre-existing bug)